From: Yushan Zhou <katrinzhou@xxxxxxxxxxx> The variable err is reassigned before the assigned value works. Cleanup unused assignments reported by Coverity. Addresses-Coverity: ("UNUSED_VALUE") Signed-off-by: Yushan Zhou <katrinzhou@xxxxxxxxxxx> --- drivers/infiniband/hw/cxgb4/cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index c16017f6e8db..3462fe991f93 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -1590,7 +1590,6 @@ static int process_mpa_reply(struct c4iw_ep *ep, struct sk_buff *skb) insuff_ird = 1; } if (insuff_ird) { - err = -ENOMEM; ep->ird = resp_ord; ep->ord = resp_ird; } @@ -1655,7 +1654,7 @@ static int process_mpa_reply(struct c4iw_ep *ep, struct sk_buff *skb) attrs.ecode = MPA_NOMATCH_RTR; attrs.next_state = C4IW_QP_STATE_TERMINATE; attrs.send_term = 1; - err = c4iw_modify_qp(ep->com.qp->rhp, ep->com.qp, + c4iw_modify_qp(ep->com.qp->rhp, ep->com.qp, C4IW_QP_ATTR_NEXT_STATE, &attrs, 1); err = -ENOMEM; disconnect = 1; @@ -1674,7 +1673,7 @@ static int process_mpa_reply(struct c4iw_ep *ep, struct sk_buff *skb) attrs.ecode = MPA_INSUFF_IRD; attrs.next_state = C4IW_QP_STATE_TERMINATE; attrs.send_term = 1; - err = c4iw_modify_qp(ep->com.qp->rhp, ep->com.qp, + c4iw_modify_qp(ep->com.qp->rhp, ep->com.qp, C4IW_QP_ATTR_NEXT_STATE, &attrs, 1); err = -ENOMEM; disconnect = 1; -- 2.27.0