Re: [PATCH] RDMA/qib: Use the bitmap API when applicable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 17/07/2022 à 20:05, Leon Romanovsky a écrit :
On Sun, Jul 03, 2022 at 09:42:48AM +0200, Christophe JAILLET wrote:
Using the bitmap API is less verbose than hand writing them.
It also improves the semantic.

While at it, initialize the bitmaps. It can't hurt.

Fixes: f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters")
Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---
  drivers/infiniband/hw/qib/qib_iba7322.c | 23 ++++++++---------------
  1 file changed, 8 insertions(+), 15 deletions(-)


I removed the Fixes line as there is no bug in changed code, just update
to use better in-kernel API.

NP for me.

I added the Fixes tag in case the apparently missing zeroing of the bitmaps was a potential issue. I've not looked enough at the code to make sure if it was needed or not.

CJ


Thanks, applied.





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux