On 7/8/22 00:23, lizhijian@xxxxxxxxxxx wrote:
> Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx>
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index 69fc35485e60..35a249727435 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -15,8 +15,7 @@ static int next_opcode(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
> u32 opcode);
>
> static inline void retry_first_write_send(struct rxe_qp *qp,
> - struct rxe_send_wqe *wqe,
> - unsigned int mask, int npsn)
> + struct rxe_send_wqe *wqe, int npsn)
> {
> int i;
>
> @@ -83,7 +82,7 @@ static void req_retry(struct rxe_qp *qp)
> if (mask & WR_WRITE_OR_SEND_MASK) {
> npsn = (qp->comp.psn - wqe->first_psn) &
> BTH_PSN_MASK;
> - retry_first_write_send(qp, wqe, mask, npsn);
> + retry_first_write_send(qp, wqe, npsn);
> }
>
> if (mask & WR_READ_MASK) {
This is correct but should have a body describing what you are doing and why.
A target branch would also help. E.g. [PATCH for-next].
Bob
