> Subject: RE: [Patch v4 10/12] net: mana: Define max values for SGL entries > > > From: longli@xxxxxxxxxxxxxxxxx <longli@xxxxxxxxxxxxxxxxx> > > Sent: Wednesday, June 15, 2022 7:07 PM ... > > The number of maximum SGl entries should be computed from the maximum > s/SGl/SGL > > > @@ -436,6 +436,13 @@ struct gdma_wqe { #define MAX_TX_WQE_SIZE 512 > > #define MAX_RX_WQE_SIZE 256 > > > > +#define MAX_TX_WQE_SGL_ENTRIES ((GDMA_MAX_SQE_SIZE - \ > > + sizeof(struct gdma_sge) - INLINE_OOB_SMALL_SIZE) / \ > > + sizeof(struct gdma_sge)) > > + > > +#define MAX_RX_WQE_SGL_ENTRIES ((GDMA_MAX_RQE_SIZE - \ > > + sizeof(struct gdma_sge)) / sizeof(struct gdma_sge)) > > Can we make these '\' chars aligned? :-) Please refer to the definiton of > "lock_requestor" in include/linux/hyperv.h. Will fix this. > > Reviewed-by: Dexuan Cui <decui@xxxxxxxxxxxxx>