> From: longli@xxxxxxxxxxxxxxxxx <longli@xxxxxxxxxxxxxxxxx> > Sent: Wednesday, June 15, 2022 7:07 PM ... > +static int add_adev(struct gdma_dev *gd) > +{ > + int ret = 0; No need to initialize it to 0. > + struct mana_adev *madev; > + struct auxiliary_device *adev; davem would require the reverse xmas tree order :-) Reviewed-by: Dexuan Cui <decui@xxxxxxxxxxxxx>