Re: [PATCH 1/1] RDMA/rxe: Fix qp error handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 25, 2022 at 02:29:06PM +0200, Haris Iqbal wrote:
> > diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> > index 9d995854a174..d0bc195b572f 100644
> > --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
> > +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> > @@ -432,7 +432,6 @@ static int rxe_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *init,
> >         return 0;
> >
> >  qp_init:
> > -       rxe_put(qp);
> 
> Does this mean that in case rxe_qp_init_resp fails (rxe_qp_init_req
> had succeeded), we will NOT end up calling rxe_qp_do_cleanup? If so,
> would we miss shutting down and releasing qp->sk?

Zhu??

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux