Re: [PATCH v2] linux/dim: Fix divide 0 in RDMA DIM.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 27, 2022 at 07:30:36PM +0800, Tao Liu wrote:
> We hit a divide 0 error in ofed 5.1.2.3.7.1. It is caused in
> rdma_dim_stats_compare() when prev->cpe_ratio == 0.
> 
> dim.c and rdma_dim.c in ofed share same code with upstream.
> We check the 0 case in IS_SIGNIFICANT_DIFF(), and do not change
> decision order.
> 
> Signed-off-by: Tao Liu <thomas.liu@xxxxxxxxx>
> ---
>  include/linux/dim.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I liked the commit message from v1 more.
It had proper kernel panic dump together with Fixes line.
https://lore.kernel.org/all/20220623085858.42945-1-thomas.liu@xxxxxxxxx

The change itself is ok.

Thanks,
Acked-by: Leon Romanovsky <leonro@xxxxxxxxxx>



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux