On 6/24/22 15:02, Jason Gunthorpe wrote:
> On Wed, Jun 22, 2022 at 04:12:01PM +0200, haris iqbal wrote:
>> On Thu, Jun 16, 2022 at 4:09 PM Md Haris Iqbal <haris.phnx@xxxxxxxxx> wrote:
>>>
>>> Currently rxe_invalidate_mr does invalidate for both local ops, and remote
>>> ones. This means that MR being invalidated is compared with rkey for both,
>>> which is incorrect. For local invalidate, comparison should happen with
>>> lkey, and for the remote one, it should happen with rkey.
>>>
>>> This commit splits the rxe_invalidate_mr into local and remote versions.
>>> Each of them does comparison the right way as described above (with lkey
>>> for local, and rkey for remote).
>>>
>>> Fixes: 3902b429ca14 ("RDMA/rxe: Implement invalidate MW operations")
>>> Cc: rpearsonhpe@xxxxxxxxx
>>> Signed-off-by: Md Haris Iqbal <haris.phnx@xxxxxxxxx>
>
>> ping.
>
> The commit message makes sense to me - is anyone else working on rxe
> going to test or review this patch?
>
> There are now many patches for rxe that I would like the rxe community
> to mutually review/test/ack.
>
> Jason
I have reviewed this patch. Haris and I discussed it after v1 and we agreed to
this for v2.
Reviewed-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
