Re: [PATCH for-next v11 08/11] RDMA/erdma: Add connection management (CM) support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 6/16/22 5:11 PM, Stefan Metzmacher wrote:

Am 15.06.22 um 03:52 schrieb Cheng Xu:
ERDMA's transport protocol is iWarp, so the driver must support CM
interface. In CM part, we use the same way as SoftiWarp: using kernel
socket to set up the connection, then performing MPA negotiation in
kernel. So, this part of code mainly comes from SoftiWarp, base on it,
we add some more features, such as non-blocking iw_connect implementation.

It would be great to have common parts to be unified in the long run
otherwise fixes are only applied to one version.


Yeah, it's looks good. But for now I think it is better to keep the
respective implementations. Because erdma and siw have different
purposes: siw aims to provides a standard iWarp implementation in
kernel, while erdma is a RDMA adapter in our cloud, needing fit our
hardware and the special network environment. There are already some
differences, and I'm not sure there will be more or not in the future.
We may consider it in the future.

Thanks your advice.
Cheng Xu






[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux