looks it's duplicated with https://patchwork.kernel.org/project/linux-rdma/patch/20220410113513.27537-1-yangx.jy@xxxxxxxxxxx/ and it was already applied. On 19/05/2022 16:30, Chengguang Xu wrote: > Currently in rxe_requester() we just skip further operation > instead of going error handling when detecting invalid opcode. > > IMO, it should goto error handling just like other errors. > > Signed-off-by: Chengguang Xu <cgxu519@xxxxxxxxxxxx> > --- > drivers/infiniband/sw/rxe/rxe_req.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c > index ae5fbc79dd5c..8a1cff80a68e 100644 > --- a/drivers/infiniband/sw/rxe/rxe_req.c > +++ b/drivers/infiniband/sw/rxe/rxe_req.c > @@ -661,7 +661,7 @@ int rxe_requester(void *arg) > opcode = next_opcode(qp, wqe, wqe->wr.opcode); > if (unlikely(opcode < 0)) { > wqe->status = IB_WC_LOC_QP_OP_ERR; > - goto exit; > + goto err; > } > > mask = rxe_opcode[opcode].mask;
