Re: [PATCH for-next] RDMA/core: Fix wrong rkey in test_qp_ex_rc_bind_mw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 18, 2022 at 11:23 PM Bob Pearson <rpearsonhpe@xxxxxxxxx> wrote:
>
> The current test_qp_ex_rc_bind_mw in tests/test_qpex.py uses an incorrect
> value for the new_rkey based on the old mr.rkey. This patch fixes that
> behavior by basing the new rkey on the old mw.rkey instead.
>
> Before this patch the test will fail for the rxe driver about 1 in 256
> tries since randomly that is the freguency of new_rkeys which have the
> same 8 bit key portion as the current mw which is not allowed. With
> this patch those errors do not occur.
>
> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>

This is for rdma-core? It had better add "for rdma core" in the subject line.

Zhu Yanjun

> ---
>  tests/test_qpex.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/test_qpex.py b/tests/test_qpex.py
> index 8f3f338e..a4c99910 100644
> --- a/tests/test_qpex.py
> +++ b/tests/test_qpex.py
> @@ -300,7 +300,7 @@ class QpExTestCase(RDMATestCase):
>              if ex.error_code == errno.EOPNOTSUPP:
>                  raise unittest.SkipTest('Memory Window allocation is not supported')
>              raise ex
> -        new_key = inc_rkey(server.mr.rkey)
> +        new_key = inc_rkey(mw.rkey)
>          server.qp.wr_bind_mw(mw, new_key, bind_info)
>          server.qp.wr_complete()
>          u.poll_cq(server.cq)
> --
> 2.34.1
>



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux