On Tue, May 17, 2022 at 09:51:44AM -0500, Bob Pearson wrote: > On 5/17/22 14:08, yanjun.zhu@xxxxxxxxx wrote: > > From: Zhu Yanjun <yanjun.zhu@xxxxxxxxx> > > > > Compact the function and move it to the header file. > I have two issues with this patch. > > There is no advantage of having an inline function in a header file > that is only called once. The compiler is perfectly capable of (and does) > inlining a static function in a .c file if only called once. This just > makes the code harder to read. That is only if the function is static in the compilation unit, in this case the only call site is in a different compilation unit That still doesn't excuse putting it in a header file, but it does suggest it could be just moved and made static. > There is a patch in for-rc that gets rid of read.mr in favor of an rkey. > This patch is out of date. You are resending that with some fix? Jason
