On 5/10/22 9:18 PM, Jason Gunthorpe wrote:
On Thu, Apr 21, 2022 at 03:17:47PM +0800, Cheng Xu wrote:
Signed-off-by: Cheng Xu <chengyou@xxxxxxxxxxxxxxxxx>
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index 33d3ce9c888e..cc6a7ff88ff3 100644
+++ b/drivers/infiniband/Kconfig
@@ -92,6 +92,7 @@ source "drivers/infiniband/hw/hns/Kconfig"
source "drivers/infiniband/hw/bnxt_re/Kconfig"
source "drivers/infiniband/hw/hfi1/Kconfig"
source "drivers/infiniband/hw/qedr/Kconfig"
+source "drivers/infiniband/hw/erdma/Kconfig"
source "drivers/infiniband/sw/rdmavt/Kconfig"
source "drivers/infiniband/sw/rxe/Kconfig"
source "drivers/infiniband/sw/siw/Kconfig"
keep sorted
OK, I thought the order follows the rule: "comes first, appears first",
so I add our drivers to the tail of "drivers/infiniband/hw/..."
Since the current list is not sorted, and if it should be, I will fix
this in next version.
diff --git a/drivers/infiniband/hw/Makefile b/drivers/infiniband/hw/Makefile
index fba0b3be903e..6b3a88046125 100644
+++ b/drivers/infiniband/hw/Makefile
@@ -13,3 +13,4 @@ obj-$(CONFIG_INFINIBAND_HFI1) += hfi1/
obj-$(CONFIG_INFINIBAND_HNS) += hns/
obj-$(CONFIG_INFINIBAND_QEDR) += qedr/
obj-$(CONFIG_INFINIBAND_BNXT_RE) += bnxt_re/
+obj-$(CONFIG_INFINIBAND_ERDMA) += erdma/
diff --git a/drivers/infiniband/hw/erdma/Kconfig b/drivers/infiniband/hw/erdma/Kconfig
new file mode 100644
index 000000000000..c90f2be1ea63
+++ b/drivers/infiniband/hw/erdma/Kconfig
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: GPL-2.0-only
+config INFINIBAND_ERDMA
+ tristate "Alibaba Elastic RDMA Adapter (ERDMA) support"
+ depends on PCI_MSI && 64BIT && !CPU_BIG_ENDIAN
Why !CPU_BIG_ENDIAN? That is usually not OK.
we want use !CPU_BIG_ENDIAN to disable the erdma compilation on big
endian machine, because we only have little endian machines, and
don't support big endian machines. I have no idea why it is usually not
OK, could you explain it any more?
Thanks
Did you run sparse on this?
No, I will check this. I think this may be OK, because EFA also use
!CPU_BIG_ENDIAN in the same way.
Thanks,
Cheng Xu
Jason
