On Wed, May 04, 2022 at 03:28:17PM -0500, Bob Pearson wrote:
> rxe_mcast.c currently uses _irqsave spinlocks for rxe->mcg_lock
> while rxe_recv.c uses _bh spinlocks for the same lock.
>
> Additionally the current code issues a warning that _irqrestore
> is restoring hardware interrupts while some interrupts are
> enabled. This is traced to calls to the calls to dev_mc_add/del().
>
> Change the locking of rxe->mcg_lock in rxe_mcast.c to use
> spin_(un)lock_bh() which matches that in rxe_recv.c. Also move
> the calls to dev_mc_add and dev_mc_del outside of spinlocks.
>
> Fixes: 6090a0c4c7c6 ("RDMA/rxe: Cleanup rxe_mcast.c")
> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
> ---
> v2
> Addressed comments from Jason re not placing calls to dev_mc_add/del
> inside of spinlocks.
I split this into two patches and put it into for-rc
Please check, and try to write commit messages in this style - "Fix
'some other commit'" is not a good subject, state what bug the patch
is correcting.
One patch per bug
Include the oops messages in the commit messages.
Jason
