On Wed, Apr 13, 2022 at 12:33:39PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@xxxxxxxxxx> > > The commit mentioned in Fixes line removed the function that was > called to check validity of esp_aes_gcm attribute. Sadly, that > is_valid_esp_aes_gcm() returned success even for specs without > esp_aes_gcm at all. > > So the right fix will be to remove whole if () and such fix > the following error observed in smatch too. > > drivers/infiniband/hw/mlx5/fs.c:1126 _create_flow_rule() > warn: duplicate check 'is_egress' (previous on line 1098) > > Fixes: de8bdb476908 ("RDMA/mlx5: Drop crypto flow steering API") > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx> > --- > drivers/infiniband/hw/mlx5/fs.c | 5 ----- > 1 file changed, 5 deletions(-) Applied to for-next, thanks Jason