On Wed, Apr 06, 2022 at 07:02:36AM +0000, Tian, Kevin wrote: > > So like this: > > > > int vfio_register_group_dev(struct vfio_device *device) > > { > > + if (!dev_is_dma_coherent(device->dev)) > > + return -EINVAL; > > + > > return __vfio_register_dev(device, > > vfio_group_find_or_alloc(device->dev)); > > } > > > > I fixed it up. > > > > if that is the case should it also apply to usnic and vdpa in the first > patch (i.e. fail the probe)? Ideally, but I don't want to mess with existing logic in these drivers.. Thanks, Jason