On Tue, Mar 22, 2022 at 12:13:31PM +0200, Ido Schimmel wrote: > On Thu, Mar 17, 2022 at 09:37:22PM +0200, Ido Schimmel wrote: > > On Thu, Mar 17, 2022 at 08:52:49PM +0200, Vladimir Oltean wrote: > > > I'd just like the 'reclassify' action to be propagated in some reasonable > > > way to flow offload, considering that at the moment the error is quite cryptic. > > > > OK, will check next week. Might be best to simply propagate extack to > > offload_act_setup() and return a meaningful message in > > tcf_police_offload_act_setup(). There are a bunch of other actions whose > > callback simply returns '-EOPNOTSUPP' that can benefit from it. > > # tc filter add dev dummy0 ingress protocol ip flower skip_sw ip_proto icmp action police rate 100Mbit burst 10000 > Error: act_police: Offload not supported when conform/exceed action is "reclassify". > We have an error talking to the kernel > > Available here: > https://github.com/idosch/linux/commits/tc_extack > > I plan to submit the patches after net-next reopens. Thanks. I've tested these partially and at least the case that I reported is now covered.
