On 2022/4/1 12:50, Leon Romanovsky wrote:
> On Fri, Apr 01, 2022 at 03:52:37AM +0000, yangx.jy@xxxxxxxxxxx wrote:
>> On 2022/4/1 1:19, Leon Romanovsky wrote:
>>
>> ret = finish_packet(qp, av, wqe, &pkt, skb, payload);
>> if (unlikely(ret)) {
>> pr_debug("qp#%d Error during finish packet\n", qp_num(qp));
>> + if (ah)
>>
>>
>> No, ah can't be NULL. This is why I proposed to clean rxe_get_av() too.
>> **ahp is not NULL, as an input to that function and in all flows it is
>> updated with new ah pointer. If it can't update, the NULL will be
>> returned and rxe_requester() will exit.
>
> Please use plain-text friendly email client.
Hi Leon,
Thanks for your reminder.
>
>>
>> Hi Leon,
>>
>> If ah_num is 0 in rxe_get_av(), rxe_get_av() returns not NULL (i.e. av is not NULL) and ah is NULL.
>> In this case, I think we can reach here and ah is NULL.
>> BTW, I don't want to mix the fix and the change of rxe_get_av()'s logic.
>
> ok, no problem.
^_^
Best Regards,
Xiao Yang
>
> Thanks
>
>>
>> Best Regards,
>>
>> Xiao Yang
