On Fri, Mar 18, 2022 at 07:43:21PM +0800, Wenpeng Liang wrote:
> > +static int erdma_set_ceq_irq(struct erdma_dev *dev, u16 ceqn)
> > +{
> > + struct erdma_eq_cb *eqc = &dev->ceqs[ceqn];
> > + cpumask_t affinity_hint_mask;
> > + u32 cpu;
> > + int err;
> > +
> > + snprintf(eqc->irq_name, ERDMA_IRQNAME_SIZE, "erdma-ceq%u@pci:%s",
> > + ceqn, pci_name(dev->pdev));
>
> Parameters in parentheses are not vertically aligned, a space is missing before "ceqn".
Generally I will recommend such a large amount of code be run through
clang-format and the good things it changes be merged. Most of what it
suggests is good kernel style
Jason
