Re: [PATCH for-next v4 05/12] RDMA/erdma: Add cmdq implementation

[Wenpeng Liang <liangwenpeng@xxxxxxxxxx>]

On 2022/3/14 14:47, Cheng Xu wrote:
<...>
> +int erdma_cmdq_init(struct erdma_dev *dev)
> +{
> +	int err, i;
> +	struct erdma_cmdq *cmdq = &dev->cmdq;
> +	u32 status, ctrl;

Hi, Jason and Leon

Defining and initializing variables in the form of an inverted triangle at
the head of the function can make the code clearer. The kernel's coding-style
does not specify this behavior, and the various kernel subsystems do not seem
to have formed a unified opinion. Does our RDMA subsystem recommend this?

struct erdma_cmdq *cmdq = &dev->cmdq;
u32 status, ctrl;
int err, i;

Thanks,
Wenpeng