Re: [PATCH for-next v10 07/11] RDMA/rxe: Fix ref error in rxe_av.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 25, 2022 at 01:57:47PM -0600, Bob Pearson wrote:
> The commit referenced below can take a reference to the AH which is
> never dropped. This only happens in the UD request path. This patch
> optionally passes that AH back to the caller so that it can hold the
> reference while the AV is being accessed and then drop it. Code to
> do this is added to rxe_req.c. The AV is also passed to rxe_prepare
> in rxe_net.c as an optimization.
> 
> Fixes: e2fe06c90806 ("RDMA/rxe: Lookup kernel AH from ah index in UD WQEs")
> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
> ---
>  drivers/infiniband/sw/rxe/rxe_av.c   | 19 +++++++++-
>  drivers/infiniband/sw/rxe/rxe_loc.h  |  5 ++-
>  drivers/infiniband/sw/rxe/rxe_net.c  | 17 +++++----
>  drivers/infiniband/sw/rxe/rxe_req.c  | 55 +++++++++++++++++-----------
>  drivers/infiniband/sw/rxe/rxe_resp.c |  2 +-
>  5 files changed, 63 insertions(+), 35 deletions(-)

This should be ordered earlier as the prior patch turns this into a
bigger problem?

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux