Re: [PATCH v1 1/1] IB/hfi1: Don't cast parameter in bit operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/23/22 4:44 PM, David Laight wrote:
> From: Andy Shevchenko
>> Sent: 23 February 2022 18:54
>>
>> While in this particular case it would not be a (critical) issue,
>> the pattern itself is bad and error prone in case somebody blindly
>> copies to their code.
> 
> It is horribly wrong on BE systems.

Note that this driver has in Kconfig: depends on X86_64.
However it's a good point about not wanting anyone to blindly copy.

-Denny



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux