Since almost all the drivers that support to offload police action make the similar validation, if it make sense to add the validation in the file of flow_offload.h or flow_offload.c? Then the other drivers do not need to make the similar validation. WDYT? On Tuesday, February 22, 2022 6:10 PM, Vladimir wrote: >On Tue, Feb 22, 2022 at 01:58:23AM +0000, Jianbo Liu wrote: >> Hi Vladimir, >> >> I'd love to hear your suggestion regarding where this validate >> function to be placed for drivers/net/ethernet/mscc, as it will be >> used by both ocelot_net.c and ocelot_flower.c. >> >> Thanks! >> Jianbo > >Try the attached patch on top of yours.