On Thu, Feb 17, 2022 at 03:50:02AM +0000, yangx.jy@xxxxxxxxxxx wrote: > On 2021/12/30 20:14, Xiao Yang wrote: > > The IB SPEC v1.5[1][2] added new RDMA operations (Atomic Write and Flush). > > This patchset makes SoftRoCE support new RDMA Atomic Write on RC service. > > > > I added RDMA Atomic Write API and a rdma_atomic_write example on my > > rdma-core repository[3]. You can verify the patchset by building and > > running the rdma_atomic_write example. > > server: > > $ ./rdma_atomic_write_server -s [server_address] -p [port_number] > > client: > > $ ./rdma_atomic_write_client -s [server_address] -p [port_number] > > Hi Leon, > > Do you think when I should post the userspace patchset to rdma-core? > > I'm not sure if I should post it to rdma-core as a PR until the kernel > patchset is merged? For any UAPI changes, we require to present actual user space part. So the PR to rdma-core is needed in order to merge the kernel series. In this PR, the first patch is created with "kernel-headers/update --not-final" script against local version of kernel headers. Once the kernel part is merged, you will update that first patch and force push the rdma-core PR. Thanks > > Best Regards, > > Xiao Yang > > > > > [1]: https://www.infinibandta.org/ibta-specification/ # login required > > [2]: https://www.infinibandta.org/wp-content/uploads/2021/08/IBTA-Overview-of-IBTA-Volume-1-Release-1.5-and-MPE-2021-08-17-Secure.pptx > > [3]: https://github.com/yangx-jy/rdma-core > > > > BTW: This patchset also needs the following fix. > > https://www.spinics.net/lists/linux-rdma/msg107838.html > > > > Xiao Yang (2): > > RDMA/rxe: Rename send_atomic_ack() and atomic member of struct > > resp_res > > RDMA/rxe: Add RDMA Atomic Write operation > > > > drivers/infiniband/sw/rxe/rxe_comp.c | 4 ++ > > drivers/infiniband/sw/rxe/rxe_opcode.c | 18 ++++++++ > > drivers/infiniband/sw/rxe/rxe_opcode.h | 3 ++ > > drivers/infiniband/sw/rxe/rxe_qp.c | 5 ++- > > drivers/infiniband/sw/rxe/rxe_req.c | 10 +++-- > > drivers/infiniband/sw/rxe/rxe_resp.c | 59 ++++++++++++++++++++------ > > drivers/infiniband/sw/rxe/rxe_verbs.h | 2 +- > > include/rdma/ib_pack.h | 2 + > > include/rdma/ib_verbs.h | 2 + > > include/uapi/rdma/ib_user_verbs.h | 2 + > > 10 files changed, 88 insertions(+), 19 deletions(-) > >
