Re: [PATCH for-next] RDMA/rxe: Revert changes from irqsave to bh locks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 15, 2022 at 01:44:49PM -0600, Bob Pearson wrote:
> A previous patch replaced all irqsave locks in rxe with bh locks.
> This ran into problems because rdmacm has a bad habit of
> calling rdma verbs APIs while disabling irqs. This is not allowed
> during spin_unlock_bh() causing programs that use rdmacm to fail.
> This patch reverts the changes to locks that had this problem or
> got dragged into the same mess. After this patch blktests/check -q srp
> now runs correctly.
> 
> This patch applies cleanly to current for-next
> 
> commit: 2f1b2820b546 ("Merge branch 'irdma_dscp' into rdma.git for-next")
> 
> Reported-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxx>
> Reported-by: Bart Van Assche <bvanassche@xxxxxxx>
> Fixes: 21adfa7a3c4e ("RDMA/rxe: Replace irqsave locks with bh locks")
> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
> ---
>  drivers/infiniband/sw/rxe/rxe_cq.c    | 20 +++++++++++-------
>  drivers/infiniband/sw/rxe/rxe_mcast.c | 19 ++++++++++-------
>  drivers/infiniband/sw/rxe/rxe_pool.c  | 30 ++++++++++++++++-----------
>  drivers/infiniband/sw/rxe/rxe_queue.c | 10 +++++----
>  drivers/infiniband/sw/rxe/rxe_resp.c  | 11 +++++-----
>  drivers/infiniband/sw/rxe/rxe_verbs.c | 27 ++++++++++++++----------
>  6 files changed, 69 insertions(+), 48 deletions(-)

Applied to for-next, thanks

I also rebased the other patches I took on top of this, you should
probably check the wip branch

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux