On 2022/02/14 12:44, Tejun Heo wrote: > Hello, > > On Mon, Feb 14, 2022 at 10:08:00AM +0900, Tetsuo Handa wrote: >> + destroy_workqueue(srp_tl_err_wq); >> >> Then, we can call WARN_ON() if e.g. flush_workqueue() is called on system-wide workqueues. > > Yeah, this is the right thing to do. It makes no sense at all to call > flush_workqueue() on the shared workqueues as the caller has no idea what > it's gonna end up waiting for. It was on my todo list a long while ago but > slipped through the crack. If anyone wanna take a stab at it (including > scrubbing the existing users, of course), please be my guest. > > Thanks. > OK. Then, I propose below patch. If you are OK with this approach, I can keep this via my tree as a linux-next only experimental patch for one or two weeks, in order to see if someone complains.
