> On 31 Jan 2022, at 10:45, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> The failure to allocate memory during MLX4_DEV_EVENT_PORT_MGMT_CHANGE
> event handler will cause skip the assignment logic, but ib_dispatch_event()
> will be called anyway.
>
> Fix it by calling to return instead of break after memory allocation
> failure.
>
> Fixes: 00f5ce99dc6e ("mlx4: Use port management change event instead of smp_snoop")
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
LGTM,
Reviewed-by: Håkon Bugge <haakon.bugge@xxxxxxxxxx>
Thxs, Håkon
> ---
> drivers/infiniband/hw/mlx4/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
> index 1c3d97229988..93b1650eacfa 100644
> --- a/drivers/infiniband/hw/mlx4/main.c
> +++ b/drivers/infiniband/hw/mlx4/main.c
> @@ -3237,7 +3237,7 @@ static void mlx4_ib_event(struct mlx4_dev *dev, void *ibdev_ptr,
> case MLX4_DEV_EVENT_PORT_MGMT_CHANGE:
> ew = kmalloc(sizeof *ew, GFP_ATOMIC);
> if (!ew)
> - break;
> + return;
>
> INIT_WORK(&ew->work, handle_port_mgmt_change_event);
> memcpy(&ew->ib_eqe, eqe, sizeof *eqe);
> --
> 2.34.1
>
