In rxe_mcast.c and rxe_recv.c replace 'grp' by 'mcg' and 'mce' by 'mca'.
Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
---
drivers/infiniband/sw/rxe/rxe_mcast.c | 102 +++++++++++++-------------
drivers/infiniband/sw/rxe/rxe_recv.c | 8 +-
2 files changed, 55 insertions(+), 55 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_mcast.c b/drivers/infiniband/sw/rxe/rxe_mcast.c
index 39f38ee665f2..ed1b9ca65da3 100644
--- a/drivers/infiniband/sw/rxe/rxe_mcast.c
+++ b/drivers/infiniband/sw/rxe/rxe_mcast.c
@@ -31,33 +31,33 @@ static struct rxe_mcg *create_grp(struct rxe_dev *rxe,
union ib_gid *mgid)
{
int err;
- struct rxe_mcg *grp;
+ struct rxe_mcg *mcg;
- grp = rxe_alloc_locked(&rxe->mc_grp_pool);
- if (!grp)
+ mcg = rxe_alloc_locked(&rxe->mc_grp_pool);
+ if (!mcg)
return ERR_PTR(-ENOMEM);
- rxe_add_ref(grp);
+ rxe_add_ref(mcg);
- INIT_LIST_HEAD(&grp->qp_list);
- spin_lock_init(&grp->mcg_lock);
- grp->rxe = rxe;
- rxe_add_key_locked(grp, mgid);
+ INIT_LIST_HEAD(&mcg->qp_list);
+ spin_lock_init(&mcg->mcg_lock);
+ mcg->rxe = rxe;
+ rxe_add_key_locked(mcg, mgid);
err = rxe_mcast_add(rxe, mgid);
if (unlikely(err)) {
- rxe_drop_key_locked(grp);
- rxe_drop_ref(grp);
+ rxe_drop_key_locked(mcg);
+ rxe_drop_ref(mcg);
return ERR_PTR(err);
}
- return grp;
+ return mcg;
}
static int rxe_mcast_get_grp(struct rxe_dev *rxe, union ib_gid *mgid,
- struct rxe_mcg **grp_p)
+ struct rxe_mcg **mcgp)
{
int err;
- struct rxe_mcg *grp;
+ struct rxe_mcg *mcg;
struct rxe_pool *pool = &rxe->mc_grp_pool;
if (rxe->attr.max_mcast_qp_attach == 0)
@@ -65,47 +65,47 @@ static int rxe_mcast_get_grp(struct rxe_dev *rxe, union ib_gid *mgid,
write_lock_bh(&pool->pool_lock);
- grp = rxe_pool_get_key_locked(pool, mgid);
- if (grp)
+ mcg = rxe_pool_get_key_locked(pool, mgid);
+ if (mcg)
goto done;
- grp = create_grp(rxe, pool, mgid);
- if (IS_ERR(grp)) {
+ mcg = create_grp(rxe, pool, mgid);
+ if (IS_ERR(mcg)) {
write_unlock_bh(&pool->pool_lock);
- err = PTR_ERR(grp);
+ err = PTR_ERR(mcg);
return err;
}
done:
write_unlock_bh(&pool->pool_lock);
- *grp_p = grp;
+ *mcgp = mcg;
return 0;
}
static int rxe_mcast_add_grp_elem(struct rxe_dev *rxe, struct rxe_qp *qp,
- struct rxe_mcg *grp)
+ struct rxe_mcg *mcg)
{
int err;
struct rxe_mca *mca, *new_mca;
/* check to see if the qp is already a member of the group */
- spin_lock_bh(&grp->mcg_lock);
- list_for_each_entry(mca, &grp->qp_list, qp_list) {
+ spin_lock_bh(&mcg->mcg_lock);
+ list_for_each_entry(mca, &mcg->qp_list, qp_list) {
if (mca->qp == qp) {
- spin_unlock_bh(&grp->mcg_lock);
+ spin_unlock_bh(&mcg->mcg_lock);
return 0;
}
}
- spin_unlock_bh(&grp->mcg_lock);
+ spin_unlock_bh(&mcg->mcg_lock);
/* speculative alloc new mca without using GFP_ATOMIC */
new_mca = kzalloc(sizeof(*mca), GFP_KERNEL);
if (!new_mca)
return -ENOMEM;
- spin_lock_bh(&grp->mcg_lock);
+ spin_lock_bh(&mcg->mcg_lock);
/* re-check to see if someone else just attached qp */
- list_for_each_entry(mca, &grp->qp_list, qp_list) {
+ list_for_each_entry(mca, &mcg->qp_list, qp_list) {
if (mca->qp == qp) {
kfree(new_mca);
err = 0;
@@ -113,63 +113,63 @@ static int rxe_mcast_add_grp_elem(struct rxe_dev *rxe, struct rxe_qp *qp,
}
}
- if (grp->num_qp >= rxe->attr.max_mcast_qp_attach) {
+ if (mcg->num_qp >= rxe->attr.max_mcast_qp_attach) {
err = -ENOMEM;
goto out;
}
- grp->num_qp++;
+ mcg->num_qp++;
new_mca->qp = qp;
atomic_inc(&qp->mcg_num);
- list_add(&new_mca->qp_list, &grp->qp_list);
+ list_add(&new_mca->qp_list, &mcg->qp_list);
err = 0;
out:
- spin_unlock_bh(&grp->mcg_lock);
+ spin_unlock_bh(&mcg->mcg_lock);
return err;
}
static int rxe_mcast_drop_grp_elem(struct rxe_dev *rxe, struct rxe_qp *qp,
union ib_gid *mgid)
{
- struct rxe_mcg *grp;
+ struct rxe_mcg *mcg;
struct rxe_mca *mca, *tmp;
- grp = rxe_pool_get_key(&rxe->mc_grp_pool, mgid);
- if (!grp)
+ mcg = rxe_pool_get_key(&rxe->mc_grp_pool, mgid);
+ if (!mcg)
goto err1;
- spin_lock_bh(&grp->mcg_lock);
+ spin_lock_bh(&mcg->mcg_lock);
- list_for_each_entry_safe(mca, tmp, &grp->qp_list, qp_list) {
+ list_for_each_entry_safe(mca, tmp, &mcg->qp_list, qp_list) {
if (mca->qp == qp) {
list_del(&mca->qp_list);
- grp->num_qp--;
- if (grp->num_qp <= 0)
- rxe_drop_ref(grp);
+ mcg->num_qp--;
+ if (mcg->num_qp <= 0)
+ rxe_drop_ref(mcg);
atomic_dec(&qp->mcg_num);
- spin_unlock_bh(&grp->mcg_lock);
- rxe_drop_ref(grp); /* ref from get_key */
+ spin_unlock_bh(&mcg->mcg_lock);
+ rxe_drop_ref(mcg); /* ref from get_key */
kfree(mca);
return 0;
}
}
- spin_unlock_bh(&grp->mcg_lock);
- rxe_drop_ref(grp); /* ref from get_key */
+ spin_unlock_bh(&mcg->mcg_lock);
+ rxe_drop_ref(mcg); /* ref from get_key */
err1:
return -EINVAL;
}
void rxe_mc_cleanup(struct rxe_pool_elem *elem)
{
- struct rxe_mcg *grp = container_of(elem, typeof(*grp), elem);
- struct rxe_dev *rxe = grp->rxe;
+ struct rxe_mcg *mcg = container_of(elem, typeof(*mcg), elem);
+ struct rxe_dev *rxe = mcg->rxe;
- rxe_drop_key(grp);
- rxe_mcast_delete(rxe, &grp->mgid);
+ rxe_drop_key(mcg);
+ rxe_mcast_delete(rxe, &mcg->mgid);
}
int rxe_attach_mcast(struct ib_qp *ibqp, union ib_gid *mgid, u16 mlid)
@@ -177,16 +177,16 @@ int rxe_attach_mcast(struct ib_qp *ibqp, union ib_gid *mgid, u16 mlid)
int err;
struct rxe_dev *rxe = to_rdev(ibqp->device);
struct rxe_qp *qp = to_rqp(ibqp);
- struct rxe_mcg *grp;
+ struct rxe_mcg *mcg;
- /* takes a ref on grp if successful */
- err = rxe_mcast_get_grp(rxe, mgid, &grp);
+ /* takes a ref on mcg if successful */
+ err = rxe_mcast_get_grp(rxe, mgid, &mcg);
if (err)
return err;
- err = rxe_mcast_add_grp_elem(rxe, qp, grp);
+ err = rxe_mcast_add_grp_elem(rxe, qp, mcg);
- rxe_drop_ref(grp);
+ rxe_drop_ref(mcg);
return err;
}
diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c
index 7ff6b53555f4..814a002b8911 100644
--- a/drivers/infiniband/sw/rxe/rxe_recv.c
+++ b/drivers/infiniband/sw/rxe/rxe_recv.c
@@ -234,7 +234,7 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
{
struct rxe_pkt_info *pkt = SKB_TO_PKT(skb);
struct rxe_mcg *mcg;
- struct rxe_mca *mce;
+ struct rxe_mca *mca;
struct rxe_qp *qp;
union ib_gid dgid;
int err;
@@ -257,8 +257,8 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
* single QP happen and just move on and try
* the rest of them on the list
*/
- list_for_each_entry(mce, &mcg->qp_list, qp_list) {
- qp = mce->qp;
+ list_for_each_entry(mca, &mcg->qp_list, qp_list) {
+ qp = mca->qp;
/* validate qp for incoming packet */
err = check_type_state(rxe, pkt, qp);
@@ -273,7 +273,7 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
* skb and pass to the QP. Pass the original skb to
* the last QP in the list.
*/
- if (mce->qp_list.next != &mcg->qp_list) {
+ if (mca->qp_list.next != &mcg->qp_list) {
struct sk_buff *cskb;
struct rxe_pkt_info *cpkt;
--
2.32.0
