Re: [PATCH rdma-next v2 06/11] RDMA/erdma: Add verbs header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 1/18/22 9:11 PM, Bernard Metzler wrote:

<...>

+struct erdma_qp {
+	struct ib_qp ibqp;
+	struct kref ref;
+	struct completion safe_free;
+	struct erdma_dev *dev;
+	struct erdma_cep *cep;
+	struct rw_semaphore state_lock;
+	bool is_kernel_qp;

this information is available via RDMA core.
one can always query 'rdma_is_kernel_res(&qp->ibqp.res)'
you should really look at the latest siw code 😉


Thanks, I will fix this. I referred the latest siw code, mainly for CM
part and modify_qp in verbs, other part of verbs already have lots of
differences, so I ignored. I will check them before v3 patch.

<...>

+
+struct erdma_cq {
+	struct ib_cq ibcq;
+	u32 cqn;
+
+	u32 depth;
+	u32 assoc_eqn;
+	u32 is_kernel_cq;

bogus u32 here, and can be completely removed.
use rdma_is_kernel_res(&cq->ibcq.res)

Will fix it also,

Thanks,
Cheng Xu



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux