Re: [PATCH net-next] net: fixup build after bpf header changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Thank You Jakub for the patch.

Kernel builds fine with given patch fix

Tested-by : Abdul haleem <abdhalee@xxxxxxxxxxxxxxxxxx>

On 1/4/22 9:18 AM, Jakub Kicinski wrote:

Recent bpf-next merge brought in header changes which uncovered
includes missing in net-next which were not present in bpf-next.
Build problems happen only on less-popular arches like hppa,
sparc, alpha etc.

I could repro the build problem with ice but not the mlx5 problem
Abdul was reporting. mlx5 does look like it should include filter.h,
anyway.

Reported-by: Abdul Haleem <abdhalee@xxxxxxxxxxxxxxxxxx>
Fixes: e63a02348958 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next")
Link: https://lore.kernel.org/all/7c03768d-d948-c935-a7ab-b1f963ac7eed@xxxxxxxxxxxxxxxxxx/
Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
---
CC: jesse.brandeburg@xxxxxxxxx
CC: anthony.l.nguyen@xxxxxxxxx
CC: saeedm@xxxxxxxxxx
CC: leon@xxxxxxxxxx
CC: intel-wired-lan@xxxxxxxxxxxxxxxx
CC: linux-rdma@xxxxxxxxxxxxxxx
CC: bpf@xxxxxxxxxxxxxxx
---
  drivers/net/ethernet/intel/ice/ice_nvm.c          | 2 ++
  drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 +
  2 files changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.c b/drivers/net/ethernet/intel/ice/ice_nvm.c
index cd739a2c64e8..4eb0599714f4 100644
--- a/drivers/net/ethernet/intel/ice/ice_nvm.c
+++ b/drivers/net/ethernet/intel/ice/ice_nvm.c
@@ -1,6 +1,8 @@
  // SPDX-License-Identifier: GPL-2.0
  /* Copyright (c) 2018, Intel Corporation. */

+#include <linux/vmalloc.h>
+
  #include "ice_common.h"

  /**
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index efcf9d30b131..31c911182498 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -37,6 +37,7 @@
  #include <net/geneve.h>
  #include <linux/bpf.h>
  #include <linux/if_bridge.h>
+#include <linux/filter.h>
  #include <net/page_pool.h>
  #include <net/xdp_sock_drv.h>
  #include "eswitch.h"

--
Regard's

Abdul Haleem
IBM Linux Technology Center




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux