From: Wang Qing <wangqing@xxxxxxxx> mlx5e_hv_vhca_stats_create() better return specific error than 1 Signed-off-by: Wang Qing <wangqing@xxxxxxxx> --- drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c index d290d72..04cda3d --- a/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c @@ -142,7 +142,7 @@ int mlx5e_hv_vhca_stats_create(struct mlx5e_priv *priv) PTR_ERR(agent)); kvfree(priv->stats_agent.buf); - return IS_ERR_OR_NULL(agent); + return agent ? PTR_ERR(agent) : -ENODEV; } priv->stats_agent.agent = agent; -- 2.7.4