Hi Cheng, I love your patch! Perhaps something to improve: [auto build test WARNING on rdma/for-next] [also build test WARNING on linus/master v5.16-rc6 next-20211221] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Cheng-Xu/Elastic-RDMA-Adapter-ERDMA-driver/20211221-105044 base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20211222/202112220838.tXmQUWZb-lkp@xxxxxxxxx/config) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/3b0243fb79f0f12a5b5c020c6f26c82de2c3c57e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Cheng-Xu/Elastic-RDMA-Adapter-ERDMA-driver/20211221-105044 git checkout 3b0243fb79f0f12a5b5c020c6f26c82de2c3c57e # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/infiniband/hw/erdma/erdma_cm.c: In function 'erdma_cep_set_inuse': >> drivers/infiniband/hw/erdma/erdma_cm.c:173:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 173 | int ret; | ^~~ drivers/infiniband/hw/erdma/erdma_cm.c: In function 'erdma_cm_llp_state_change': >> drivers/infiniband/hw/erdma/erdma_cm.c:1077:24: warning: variable 's' set but not used [-Wunused-but-set-variable] 1077 | struct socket *s; | ^ drivers/infiniband/hw/erdma/erdma_cm.c: In function 'erdma_create_listen': >> drivers/infiniband/hw/erdma/erdma_cm.c:1456:28: warning: variable 'r_ip' set but not used [-Wunused-but-set-variable] 1456 | u8 *l_ip, *r_ip; | ^~~~ >> drivers/infiniband/hw/erdma/erdma_cm.c:1456:21: warning: variable 'l_ip' set but not used [-Wunused-but-set-variable] 1456 | u8 *l_ip, *r_ip; | ^~~~ -- drivers/infiniband/hw/erdma/erdma_main.c: In function 'erdma_probe_dev': >> drivers/infiniband/hw/erdma/erdma_main.c:294:27: warning: variable 'ibdev' set but not used [-Wunused-but-set-variable] 294 | struct ib_device *ibdev; | ^~~~~ drivers/infiniband/hw/erdma/erdma_main.c: At top level: >> drivers/infiniband/hw/erdma/erdma_main.c:464:5: warning: no previous prototype for 'erdma_res_cb_init' [-Wmissing-prototypes] 464 | int erdma_res_cb_init(struct erdma_dev *dev) | ^~~~~~~~~~~~~~~~~ >> drivers/infiniband/hw/erdma/erdma_main.c:481:6: warning: no previous prototype for 'erdma_res_cb_free' [-Wmissing-prototypes] 481 | void erdma_res_cb_free(struct erdma_dev *dev) | ^~~~~~~~~~~~~~~~~ -- >> drivers/infiniband/hw/erdma/erdma_eq.c:169:6: warning: no previous prototype for 'erdma_intr_ceq_task' [-Wmissing-prototypes] 169 | void erdma_intr_ceq_task(unsigned long data) | ^~~~~~~~~~~~~~~~~~~ vim +/ret +173 drivers/infiniband/hw/erdma/erdma_cm.c 1d17ac4bdb13af Cheng Xu 2021-12-21 169 1d17ac4bdb13af Cheng Xu 2021-12-21 170 static void erdma_cep_set_inuse(struct erdma_cep *cep) 1d17ac4bdb13af Cheng Xu 2021-12-21 171 { 1d17ac4bdb13af Cheng Xu 2021-12-21 172 unsigned long flags; 1d17ac4bdb13af Cheng Xu 2021-12-21 @173 int ret; 1d17ac4bdb13af Cheng Xu 2021-12-21 174 retry: 1d17ac4bdb13af Cheng Xu 2021-12-21 175 spin_lock_irqsave(&cep->lock, flags); 1d17ac4bdb13af Cheng Xu 2021-12-21 176 1d17ac4bdb13af Cheng Xu 2021-12-21 177 if (cep->in_use) { 1d17ac4bdb13af Cheng Xu 2021-12-21 178 spin_unlock_irqrestore(&cep->lock, flags); 1d17ac4bdb13af Cheng Xu 2021-12-21 179 ret = wait_event_interruptible(cep->waitq, !cep->in_use); 1d17ac4bdb13af Cheng Xu 2021-12-21 180 if (signal_pending(current)) 1d17ac4bdb13af Cheng Xu 2021-12-21 181 flush_signals(current); 1d17ac4bdb13af Cheng Xu 2021-12-21 182 goto retry; 1d17ac4bdb13af Cheng Xu 2021-12-21 183 } else { 1d17ac4bdb13af Cheng Xu 2021-12-21 184 cep->in_use = 1; 1d17ac4bdb13af Cheng Xu 2021-12-21 185 spin_unlock_irqrestore(&cep->lock, flags); 1d17ac4bdb13af Cheng Xu 2021-12-21 186 } 1d17ac4bdb13af Cheng Xu 2021-12-21 187 } 1d17ac4bdb13af Cheng Xu 2021-12-21 188 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
