Re: [PATCH] net/mlx5: Remove the repeated declaration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 08, 2021 at 09:27:37AM +0800, Shaokun Zhang wrote:
> Hi Leon,
> 
> On 2021/12/7 20:40, Leon Romanovsky wrote:
> > On Tue, Dec 07, 2021 at 08:35:15PM +0800, Shaokun Zhang wrote:
> >> Function 'mlx5_esw_vport_match_metadata_supported' and
> >> 'mlx5_esw_offloads_vport_metadata_set' are declared twice, so remove
> >> the repeated declaration and blank line.
> >>
> >> Cc: Saeed Mahameed <saeedm@xxxxxxxxxx>
> >> Cc: Leon Romanovsky <leon@xxxxxxxxxx>
> >> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> >> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> >> Signed-off-by: Shaokun Zhang <zhangshaokun@xxxxxxxxxxxxx>
> >> ---
> >>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 3 ---
> >>  1 file changed, 3 deletions(-)
> >>
> > 
> > Fixes: 4f4edcc2b84f ("net/mlx5: E-Switch, Add ovs internal port mapping to metadata support")
> > 
> 
> Shall we need this tag since it is trivial cleanup patch?

I don't know about netdev policy about Fixes line.

IMHO, it should be always when the bug is fixed.

Thansk

> 
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> 
> Thanks your reply.
> 
> > .
> > 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux