On Mon, Nov 22, 2021 at 01:53:57PM +0200, Leon Romanovsky wrote:
> From: Avihai Horon <avihaih@xxxxxxxxxx>
>
> Currently, ib_find_gid() will stop searching after encountering the
> first empty GID table entry. This behavior is wrong since neither IB
> nor RoCE spec enforce tightly packed GID tables.
>
> For example, when a valid GID entry exists at index N, and if a GID
> entry is empty at index N-1, ib_find_gid() will fail to find the valid
> entry.
>
> Fix it by making ib_find_gid() continue searching even after
> encountering missing entries.
>
> Fixes: 5eb620c81ce3 ("IB/core: Add helpers for uncached GID and P_Key searches")
> Signed-off-by: Avihai Horon <avihaih@xxxxxxxxxx>
> Reviewed-by: Mark Zhang <markzhang@xxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> drivers/infiniband/core/device.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 22a4adda7981..b5d8443030d4 100644
> +++ b/drivers/infiniband/core/device.c
> @@ -2460,8 +2460,11 @@ int ib_find_gid(struct ib_device *device, union ib_gid *gid,
> for (i = 0; i < device->port_data[port].immutable.gid_tbl_len;
> ++i) {
> ret = rdma_query_gid(device, port, i, &tmp_gid);
> + if (ret == -ENOENT)
> + continue;
> if (ret)
> return ret;
There is no return code from rdma_query_gid that means stop searching,
so just write
if (ret)
continue
Jason
