On Tue, 2021-11-30 at 10:12 -0800, Tony Nguyen wrote:
> From: Shiraz Saleem <shiraz.saleem@xxxxxxxxx>
>
> vbool in ice_devlink_enable_roce_get can be assigned to a
> non-0/1 constant.
>
> Fix this assignment of vbool to be 0/1.
This one seems fine, but another use of vbool in ice still exists
drivers/net/ethernet/intel/ice/ice_devlink.c:617: value.vbool = test_bit(ICE_FLAG_RDMA_ENA, pf->flags) ? true : false;
Curiously, the vbool is defined in a union so it's possible
for the vbool value in the union to not just be 0 or 1.
> diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c b/drivers/net/ethernet/intel/ice/ice_devlink.c
[]
> @@ -436,7 +436,7 @@ ice_devlink_enable_roce_get(struct devlink *devlink, u32 id,
> {
> struct ice_pf *pf = devlink_priv(devlink);
>
> - ctx->val.vbool = pf->rdma_mode & IIDC_RDMA_PROTOCOL_ROCEV2;
> + ctx->val.vbool = pf->rdma_mode & IIDC_RDMA_PROTOCOL_ROCEV2 ? true : false;
>
> return 0;
> }
