On Fri, Nov 19, 2021 at 10:02:04PM +0800, Wenpeng Liang wrote: > From: Haoyue Xu <xuhaoyue1@xxxxxxxxxxxxx> > > The "ret" should be initialized when it is defined instead of in the loop. Why? It is a bit weird, but the code is fine as written The only suggestion I'd make is if (hns_roce_cmq_csq_done(hr_dev)) { ret = 0; for (i = 0; i < num; i++) { Just because the , operator is not so typically used like that Jason