On Wed, 17 Nov 2021 20:26:20 +0200 Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@xxxxxxxxxx> > > devlink_port_register() is in-kernel API and as such can't really fail > as long as driver author didn't make a mistake by providing already existing > port index. Instead of relying on various error prints from the driver, > convert the existence check to be WARN_ON(), so such a mistake will be > caught easier. > > As an outcome of this conversion, it was made clear that this function > should be void and devlink->lock was intended to protect addition to > port_list. Leave this error checking in please.
