Re: [v2,for-rc] RDMA/qedr: qedr crash while running rdma-tool

[Jason Gunthorpe <jgg@xxxxxxxxxx>]

On Sun, Oct 24, 2021 at 01:46:03PM +0300, Kamal Heib wrote:

> > diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
> > index dcb3653db72d..85baa4f730df 100644
> > +++ b/drivers/infiniband/hw/qedr/verbs.c
> > @@ -2744,15 +2744,20 @@ int qedr_query_qp(struct ib_qp *ibqp,
> >   	int rc = 0;
> >   	memset(&params, 0, sizeof(params));
> > +	memset(qp_attr, 0, sizeof(*qp_attr));
> > +	memset(qp_init_attr, 0, sizeof(*qp_init_attr));
> > -	rc = dev->ops->rdma_query_qp(dev->rdma_ctx, qp->qed_qp, &params);
> > +	if (qp->qed_qp)
> 
> I suggest to use "if (qp->qp_type != IB_QPT_GSI)" to match the handling of
> GSI QPs in the QEDR driver.

Alok? Time is closing to get this in before the merge window.

Jason