Re: [PATCH v6 01/12] fs/exec: make __set_task_comm always set a nul ternimated string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v6 01/12] fs/exec: make __set_task_comm always set a nul ternimated string
From: Yafang Shao <laoar.shao@xxxxxxxxx>
Date: Tue, 26 Oct 2021 09:48:47 +0800
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx>, Petr Mladek <pmladek@xxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Valentin Schneider <valentin.schneider@xxxxxxx>, Qiang Zhang <qiang.zhang@xxxxxxxxxxxxx>, robdclark <robdclark@xxxxxxxxxxxx>, christian <christian@xxxxxxxxxx>, Dietmar Eggemann <dietmar.eggemann@xxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>, David Miller <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Martin Lau <kafai@xxxxxx>, Song Liu <songliubraving@xxxxxx>, Yonghong Song <yhs@xxxxxx>, john fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, dennis.dalessandro@xxxxxxxxxxxxxxxxxxxx, mike.marciniszyn@xxxxxxxxxxxxxxxxxxxx, dledford@xxxxxxxxxx, jgg@xxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, netdev <netdev@xxxxxxxxxxxxxxx>, bpf <bpf@xxxxxxxxxxxxxxx>, "linux-perf-use." <linux-perf-users@xxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Linux MM <linux-mm@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel test robot <oliver.sang@xxxxxxxxx>, kbuild test robot <lkp@xxxxxxxxx>, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>
In-reply-to: <202110251407.6FD1411ECB@keescook>
References: <20211025083315.4752-1-laoar.shao@gmail.com> <20211025083315.4752-2-laoar.shao@gmail.com> <202110251407.6FD1411ECB@keescook>

On Tue, Oct 26, 2021 at 5:07 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> On Mon, Oct 25, 2021 at 08:33:04AM +0000, Yafang Shao wrote:
> > Make sure the string set to task comm is always nul ternimated.
>
> typo nit: "terminated"
>

Thanks for pointing this out. I will correct lt.

> >
> > Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>
>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>

Thanks for the review.

-- 
Thanks
Yafang

References:
- [PATCH v6 00/12] extend task comm from 16 to 24
  - From: Yafang Shao
- [PATCH v6 01/12] fs/exec: make __set_task_comm always set a nul ternimated string
  - From: Yafang Shao
- Re: [PATCH v6 01/12] fs/exec: make __set_task_comm always set a nul ternimated string
  - From: Kees Cook

Prev by Date: Re: [PATCH v6 12/12] kernel/kthread: show a warning if kthread's comm is truncated
Next by Date: Re: [PATCH v6 02/12] fs/exec: make __get_task_comm always get a nul terminated string
Previous by thread: Re: [PATCH v6 01/12] fs/exec: make __set_task_comm always set a nul ternimated string
Next by thread: [PATCH v6 02/12] fs/exec: make __get_task_comm always get a nul terminated string
Index(es):
- Date
- Thread

[Index of Archives] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Photo] [Yosemite News] [Yosemite Photos] [Linux Kernel] [Linux SCSI] [XFree86]