Re: [PATCH rdma-next 2/3] mlx5: use dev_addr_mod()

[Leon Romanovsky <leon@xxxxxxxxxx>]

On Thu, Oct 21, 2021 at 05:58:23AM -0700, Jakub Kicinski wrote:
> On Thu, 21 Oct 2021 12:49:53 +0300 Leon Romanovsky wrote:
> > > -	dev->dev_addr[1] = (ipriv->qpn >> 16) & 0xff;
> 
>                       ^ the original modifies starting at offset 1

Ahh, right.

> 
> > > -	dev->dev_addr[2] = (ipriv->qpn >>  8) & 0xff;
> > > -	dev->dev_addr[3] = (ipriv->qpn) & 0xff;
> > > +	addr_mod[0] = (ipriv->qpn >> 16) & 0xff;
> > > +	addr_mod[1] = (ipriv->qpn >>  8) & 0xff;
> > > +	addr_mod[2] = (ipriv->qpn) & 0xff;
> > > +	dev_addr_mod(dev, 1, addr_mod, sizeof(addr_mod));  
> >                          ^^^ It should be 0, no?