On Wed, Oct 13, 2021 at 10:46:49AM -0400, Chuck Lever wrote: > This patch series moves forward with the removal of dprintk in > SUNRPC in favor of tracepoints. This is the last step for the > svcrdma component. Makes sense to me. I would like some (very short) documentation, somewhere. Partly just for my sake! I'm not sure exactly what to recommend to bug reporters. I guess trace-cmd record -e 'sunrpc:* trace-cmd report would be a rough substitute for "rpcdebug -m rpc -s all"? Do we have a couple examples of issues that could be diagnosed with tracepoints? In the past I don't feel like I've ended up using dprintks all that much; somehow they're not usually where I need them. But maybe that's just me. And maybe as we put more thought into where tracepoints should be, they'll get more useful. Documentation/filesystems/nfs/, or the linux-nfs wiki, could be easy places to put it. Though *something* in the man pages would be nice. At a minimum, a warning in rpcdebug(8) that we're gradually phasing out dprintks. --b. > > --- > > Chuck Lever (6): > svcrdma: Remove dprintk() call sites in module handlers > svcrdma: Remove dprintk call site in svc_rdma_create_xprt() > svcrdma: Remove dprintk call site in svc_rdma_parse_connect_private() > svcrdma: Remove dprintk call sites during QP creation > svcrdma: Remove dprintk call sites during accept > svcrdma: Remove include/linux/sunrpc/debug.h > > > net/sunrpc/xprtrdma/svc_rdma.c | 9 ------ > net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 1 - > net/sunrpc/xprtrdma/svc_rdma_sendto.c | 1 - > net/sunrpc/xprtrdma/svc_rdma_transport.c | 37 ++---------------------- > 4 files changed, 3 insertions(+), 45 deletions(-) > > -- > Chuck Lever
