Re: [PATCH net-next 3/4] mlx4: remove custom dev_addr clearing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/4/2021 10:14 PM, Jakub Kicinski wrote:
mlx4_en_u64_to_mac() takes the dev->dev_addr pointer and writes
to it byte by byte. It also clears the two bytes _after_ ETH_ALEN
which seems unnecessary. dev->addr_len is set to ETH_ALEN just
before the call.

Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
---
  drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 14 ++++++--------
  1 file changed, 6 insertions(+), 8 deletions(-)


Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux