On Mon, Oct 4, 2021 at 8:47 PM Jason Gunthorpe <jgg@xxxxxxxx> wrote: > > On Mon, Oct 04, 2021 at 07:41:08AM +0200, Jinpu Wang wrote: > > Sorry, I'm really not convinced, why should we only do allowing, not > > disabling in this case? > > > > Jason, what's your suggestion? > > At least from a correctness perspective only the characters / and \0 > are forbidden, as well as any existing filenames like . and .. > > Generally it is not a great idea to restrict things too much because > it can block the full use of UTF-8 for non-English languages. > > However, I also think the sysfs in this driver is far too elaborate, > the time to complain was before this was all merged > unfortunately. Given that it is a simple enough bug fix it may as well > go ahead as-is. > > Jason Thanks Jason and Leon.
