Re: [PATCH rc] RDMA/cma: Ensure rdma_addr_cancel() happens before issuing more requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 22, 2021 at 11:01:39AM +0300, Leon Romanovsky wrote:

> > +			/* The FSM can return back to RDMA_CM_ADDR_BOUND after
> > +			 * rdma_resolve_ip() is called, eg through the error
> > +			 * path in addr_handler. If this happens the existing
> > +			 * request must be canceled before issuing a new one.
> > +			 */
> > +			if (id_priv->used_resolve_ip)
> > +				rdma_addr_cancel(&id->route.addr.dev_addr);
> > +			else
> > +				id_priv->used_resolve_ip = 1;
> 
> Why don't you never clear this field?

The only case where it can be cleared is if we have called
rdma_addr_cancel(), and since this is the only place that does it and
immediately calls rdma_resolve_ip() again, there is no reason to ever
clear it.

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux