On 2021/9/15 2:33, Jason Gunthorpe wrote: > On Thu, Sep 02, 2021 at 04:46:38PM +0800, Xiao Yang wrote: >> Make all is_user members of struct rxe_sq/rxe_cq/rxe_srq/rxe_cq >> has the same type. >> >> Signed-off-by: Xiao Yang<yangx.jy@xxxxxxxxxxx> >> drivers/infiniband/sw/rxe/rxe_cq.c | 3 +-- >> drivers/infiniband/sw/rxe/rxe_verbs.h | 2 +- >> 2 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/infiniband/sw/rxe/rxe_cq.c b/drivers/infiniband/sw/rxe/rxe_cq.c >> index aef288f164fd..fd655e41d621 100644 >> +++ b/drivers/infiniband/sw/rxe/rxe_cq.c >> @@ -81,8 +81,7 @@ int rxe_cq_from_init(struct rxe_dev *rxe, struct rxe_cq *cq, int cqe, >> return err; >> } >> >> - if (uresp) >> - cq->is_user = 1; >> + cq->is_user = uresp ? true : false; > When you resend this series we don't need any of the ternary > expressions, when things implicitly cast to bool they are converted to > 1/0 using the same logic as any other boolean expression. So just > write > > cq->is_user = uresp; Hi Jason, Thanks for your suggestion. I will update it in the next version. Best Regards, Xiao Yang > Jason
