Hi Bob, I can verify that rping works after applying this patch series.
Thanks.
Shoaib
On 9/14/21 9:42 AM, Bob Pearson wrote:
This series of patches implements several bug fixes and minor
cleanups of the rxe driver. Specifically these fix a bug exposed
by blktest.
They apply cleanly to both
commit 1b789bd4dbd48a92f5427d9c37a72a8f6ca17754 (origin/for-rc)
commit 6a217437f9f5482a3f6f2dc5fcd27cf0f62409ac (origin/for-next)
The first patch is a rewrite of an earlier patch.
It adds memory barriers to kernel to kernel queues. The logic for this
is the same as an earlier patch that only treated user to kernel queues.
Without this patch kernel to kernel queues are expected to intermittently
fail at low frequency as was seen for the other queues.
The second patch cleans up the state and type enums used by MRs.
The third patch separates the keys in rxe_mr and ib_mr. This allows
the following sequence seen in the srp driver to work correctly.
do {
ib_post_send( IB_WR_LOCAL_INV )
ib_update_fast_reg_key()
ib_map_mr_sg()
ib_post_send( IB_WR_REG_MR )
} while ( !done )
The fourth patch creates duplicate mapping tables for fast MRs. This
prevents rkeys referencing fast MRs from accessing data from an updated
map after the call to ib_map_mr_sg() call by keeping the new and old
mappings separate and atomically swapping them when a reg mr WR is
executed.
The fifth patch checks the type of MRs which receive local or remote
invalidate operations to prevent invalidating user MRs.
v3->v4:
Two of the patches in v3 were accepted in v5.15 so have been dropped
here.
The first patch was rewritten to correctly deal with queue operations
in rxe_verbs.c where the code is the client and not the server.
v2->v3:
The v2 version had a typo which broke clean application to for-next.
Additionally in v3 the order of the patches was changed to make
it a little cleaner.
Bob Pearson (5):
RDMA/rxe: Add memory barriers to kernel queues
RDMA/rxe: Cleanup MR status and type enums
RDMA/rxe: Separate HW and SW l/rkeys
RDMA/rxe: Create duplicate mapping tables for FMRs
RDMA/rxe: Only allow invalidate for appropriate MRs
drivers/infiniband/sw/rxe/rxe_comp.c | 12 +-
drivers/infiniband/sw/rxe/rxe_cq.c | 25 +--
drivers/infiniband/sw/rxe/rxe_loc.h | 2 +
drivers/infiniband/sw/rxe/rxe_mr.c | 267 ++++++++++++++++-------
drivers/infiniband/sw/rxe/rxe_mw.c | 36 ++--
drivers/infiniband/sw/rxe/rxe_qp.c | 12 +-
drivers/infiniband/sw/rxe/rxe_queue.c | 30 ++-
drivers/infiniband/sw/rxe/rxe_queue.h | 292 +++++++++++---------------
drivers/infiniband/sw/rxe/rxe_req.c | 51 ++---
drivers/infiniband/sw/rxe/rxe_resp.c | 40 +---
drivers/infiniband/sw/rxe/rxe_srq.c | 2 +-
drivers/infiniband/sw/rxe/rxe_verbs.c | 92 ++------
drivers/infiniband/sw/rxe/rxe_verbs.h | 48 ++---
13 files changed, 438 insertions(+), 471 deletions(-)
