Re: [PATCH for-next 07/12] RDMA/bnxt_re: Fix query SRQ failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 13, 2021 at 4:25 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> On Sun, Sep 12, 2021 at 11:15:21AM -0700, Selvin Xavier wrote:
> > Fill the missing parameters for the FW command while
> > querying SRQ.
> >
> > Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters")
> > Signed-off-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
> > ---
> >  drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
> > index 539b1a2..e2926dd 100644
> > --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
> > +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
> > @@ -713,6 +713,8 @@ int bnxt_qplib_query_srq(struct bnxt_qplib_res *res,
> >       sbuf = bnxt_qplib_rcfw_alloc_sbuf(rcfw, sizeof(*sb));
> >       if (!sbuf)
> >               return -ENOMEM;
> > +     req.resp_size = sizeof(*sb) / BNXT_QPLIB_CMDQE_UNITS;
> > +     req.srq_cid = cpu_to_le32(srq->id);
>
> You already have this line.

ok.. I will remove one of them. mainly the fix was for the resp_size..

Thanks
>
>    698 int bnxt_qplib_query_srq(struct bnxt_qplib_res *res,
>    699                          struct bnxt_qplib_srq *srq)
>    700 {
>    ...
>    708
>    709         RCFW_CMD_PREP(req, QUERY_SRQ, cmd_flags);
>    710         req.srq_cid = cpu_to_le32(srq->id);
>
>
> >       sb = sbuf->sb;
> >       rc = bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp,
> >                                         (void *)sbuf, 0);
> > --
> > 2.5.5
> >

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux