On Sun, Sep 12, 2021 at 11:15:17AM -0700, Selvin Xavier wrote:
> From: Edwin Peer <edwin.peer@xxxxxxxxxxxx>
>
> Use separate buffers for the request and response data. Eventhough
> the response data is not used, providing the correct length is
> appropriate.
>
> Signed-off-by: Edwin Peer <edwin.peer@xxxxxxxxxxxx>
> Signed-off-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/bnxt_re/main.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
> index e4f39d8..4214674 100644
> --- a/drivers/infiniband/hw/bnxt_re/main.c
> +++ b/drivers/infiniband/hw/bnxt_re/main.c
> @@ -525,7 +525,8 @@ static int bnxt_re_net_stats_ctx_free(struct bnxt_re_dev *rdev,
> u32 fw_stats_ctx_id)
> {
> struct bnxt_en_dev *en_dev = rdev->en_dev;
> - struct hwrm_stat_ctx_free_input req = {0};
> + struct hwrm_stat_ctx_free_input req = {};
> + struct hwrm_stat_ctx_free_output resp = {};
> struct bnxt_fw_msg fw_msg;
> int rc = -EINVAL;
>
> @@ -539,8 +540,8 @@ static int bnxt_re_net_stats_ctx_free(struct bnxt_re_dev *rdev,
>
> bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_STAT_CTX_FREE, -1, -1);
> req.stat_ctx_id = cpu_to_le32(fw_stats_ctx_id);
> - bnxt_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&req,
> - sizeof(req), DFLT_HWRM_CMD_TIMEOUT);
> + bnxt_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&resp,
> + sizeof(resp), DFLT_HWRM_CMD_TIMEOUT);
As far as I remember, you don't need to cast to void.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>
