On Thu, Sep 02, 2021 at 03:29:43PM +0000, Nikolova, Tatyana E wrote: > > > > -----Original Message----- > > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > > Sent: Monday, August 23, 2021 11:11 AM > > To: Nikolova, Tatyana E <tatyana.e.nikolova@xxxxxxxxx> > > Cc: dledford@xxxxxxxxxx; leon@xxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH v2 rdma-core] irdma: Add ice and irdma to kernel-boot > > rules > > > > On Mon, Aug 23, 2021 at 10:48:16AM -0500, Tatyana Nikolova wrote: > > > Add ice and irdma to kernel-boot rules so that these devices are > > > recognized as iWARP and RoCE capable. > > > > > > Otherwise the port mapper service which is only relevant for iWARP > > > devices may not start automatically after boot. > > > > > > Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@xxxxxxxxx> > > > kernel-boot/rdma-description.rules | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Given that ice is both iwarp and roce, is there some better way to detect > > this? Doesn't the aux device encode it? > > Hi Jason, > > We tried a few experiments without success. The auxiliary devices alias with our driver and not ice, so maybe this is the reason? > > Here is an example of what we tried. > > udevadm info /sys/devices/pci0000:2e/0000:2e:00.0/0000:2f:00.0/ice.roce.0 > P: /devices/pci0000:2e/0000:2e:00.0/0000:2f:00.0/ice.roce.0 > E: DEVPATH=/devices/pci0000:2e/0000:2e:00.0/0000:2f:00.0/ice.roce.0 > E: DRIVER=irdma > E: MODALIAS=auxiliary:ice.roce > E: SUBSYSTEM=auxiliary > > udevadm info /sys/bus/auxiliary/devices/ice.roce.0 > P: /devices/pci0000:2e/0000:2e:00.0/0000:2f:00.0/ice.roce.0 > E: DEVPATH=/devices/pci0000:2e/0000:2e:00.0/0000:2f:00.0/ice.roce.0 > E: DRIVER=irdma > E: MODALIAS=auxiliary:ice.roce > E: SUBSYSTEM=auxiliary Everything will be much easier if you follow my initial review comment about auxiliary bus naming when irdma driver was added. The RoCE device should be: P: /devices/pci0000:2e/0000:2e:00.0/0000:2f:00.0/ice.roce.0 E: MODALIAS=auxiliary:ice.roce and the iWARP device needs to be: P: /devices/pci0000:2e/0000:2e:00.0/0000:2f:00.0/ice.iwarp.0 E: MODALIAS=auxiliary:ice.iwarp Thanks
