On Tue, Aug 24, 2021 at 09:44:26AM +0800, Mark Zhang wrote: > On 8/24/2021 3:33 AM, Jason Gunthorpe wrote: > > On Wed, Aug 18, 2021 at 02:24:18PM +0300, Mark Zhang wrote: > > > Hi, > > > > > > This series from Aharon and Neta provides an extension to the rdma > > > statistics tool that allows to add and remove optional counters > > > dynamically, using new netlink commands. > > > > > > The idea of having optional counters is to provide to the users the > > > ability to get statistics of counters that hurts performance. > > > > > > Once an optional counter was added, its statistics will be presented > > > along with all the counters, using the show command. > > > > > > Binding objects to the optional counters is currently not supported, > > > neither in auto mode nor in manual mode. > > > > > > To get the list of optional counters that are supported on this device, > > > use "rdma statistic mode supported". To see which counters are currently > > > enabled, use "rdma statistic mode". > > > > > > $ rdma statistic mode supported > > > link rocep8s0f0/1 > > > Optional-set: cc_rx_ce_pkts cc_rx_cnp_pkts cc_tx_cnp_pkts > > > link rocep8s0f1/1 > > > Optional-set: cc_rx_ce_pkts cc_rx_cnp_pkts cc_tx_cnp_pkts > > > > > > $ sudo rdma statistic add link rocep8s0f0/1 optional-set cc_rx_ce_pkts > > > $ rdma statistic mode > > > link rocep8s0f0/1 > > > Optional-set: cc_rx_ce_pkts > > > $ sudo rdma statistic add link rocep8s0f0/1 optional-set cc_tx_cnp_pkts > > > $ rdma statistic mode > > > link rocep8s0f0/1 > > > Optional-set: cc_rx_ce_pkts cc_tx_cnp_pkts > > > > This doesn't look like the right output to iproute to me, the two > > command should not be using the same tag and the output of iproute > > should always be formed to be valid input to iproute > > So it should be like this: > > $ rdma statistic mode supported > link rocep8s0f0/1 optional-set cc_rx_ce_pkts cc_rx_cnp_pkts cc_tx_cnp_pkts > link rocep8s0f1/1 optional-set cc_rx_ce_pkts cc_rx_cnp_pkts cc_tx_cnp_pkts Each netlink tag in the protocol should have a unique string in the output. So you need strings that mean "optional set supported" and "optional set currently enabled" Jason
